Repository navigation
Conversation
Signed-off-by: adibmbrk <adibmbrk@gmail.com>
|
👋 Hi @adibmbrk, thanks for contributing! For the review process to begin, please verify that the following is satisfied:
📢✨ Before we assign a reviewer:
Also check that issue requirements are satisfied & you ran Pull requests that don't follow the guidelines will be closed. Reviewer assignment can take up to 2 weeks. |
🟡 Waiting for changesOutcome: skipped — no new commits since Last updated: 2026-10-27 09:26 UTC |
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #6334 is blocked on missing screenshots. The code follows the merged RequestNewActivationLink.vue pattern (#6026) and covers all four replacements the issue lists.
CI: only Pull Request Template / Check template fails, on the screenshot placeholder. Manual QA did not run.
- blocking: screenshots missing. The PR body still has
<!-- TODO: add screenshots -->. The issue's acceptance criteria require screenshots. Add before/after for the default state, the required-field error, the invalid-email error and the error banner (force it temporarily). Add RTL and mobile widths too. - suggestion: validation now runs on every keystroke; note it in the PR body (inline).
- suggestion: validation-message assertions match on text alone; scope them to the email field (inline).
Next step: Needs a full code review by a human engineer, then manual QA once that reviewer sets Needs QA.
- The author is outside the team: confirm this should be built at all.
- User-visible files changed:
contentcuration/contentcuration/frontend/accounts/pages/resetPassword/ForgotPassword.vue. - Check that the required-field error, the invalid-email error and the error banner render correctly at mobile width and in RTL.
- Confirm that errors showing on each keystroke, rather than on blur, is acceptable.
Written by rtibblesbot, an LLM-based coding agent.
Signed-off-by: adibmbrk <adibmbrk@gmail.com>
Signed-off-by: adibmbrk <adibmbrk@gmail.com>
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #6334: both prior findings are resolved. Manual QA did not run. The UI is unverified.
Prior-finding status
RESOLVED — contentcuration/contentcuration/frontend/accounts/pages/resetPassword/ForgotPassword.vue:25 — validation runs on every keystroke instead of on blur
RESOLVED — contentcuration/contentcuration/frontend/accounts/pages/tests/forgotPassword.spec.js:50 — text assertions match anywhere on the page
Next step: Needs a full code review by a human engineer, then manual QA once that reviewer sets Needs QA.
- The author is outside the team: confirm this should be built at all.
- User-visible files changed:
contentcuration/contentcuration/frontend/accounts/pages/resetPassword/ForgotPassword.vue. - Check the email error appears only after blur or submit, and the reset link sends for a valid email.
Written by rtibblesbot, an LLM-based coding agent.
Superseded by my review of 3c46df4: no blocking findings remain.
|
@adibmbrk Thanks for your work on this PR! Could you please update it to use the required PR template? Also be sure add screenshots to help reviewers assess your changes more thoroughly, as this is frontend focused issue. |
Summary
MessageLayoutwithStudioMessageLayoutVFormwith<form>and usedgenerateFormMixinfor validation, the same way asRequestNewActivationLinkBannerwithStudioBannerEmailFieldwithStudioEmailFieldScreenshots
References
Closes #5932