Repository navigation
Apply strikethrough on Ctrl/Cmd+Shift+S in the rich text editor - #6332
Open
rtibblesbot wants to merge 1 commit into
Open
rtibblesbot wants to merge 1 commit into
rtibblesbot wants to merge 1 commit into
Conversation
The Small node's shortcut shadowed the strike mark's binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
marked this pull request as ready for review
October 25, 2026 02:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #6322. First seen: #6151.
Reviewer guidance
Suggested review: Light-touch code review, then manual QA.
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/extensions/SmallTextExtension.js.QA team: in the exercise editor, Ctrl+Shift+S (Cmd+Shift+S on Mac) now applies strikethrough. Before, it changed the line to Small text. Regressions are most probable in Small, heading and list lines, and in answers and hints.
Sign in as a channel editor. Add a new exercise and open its Questions tab.
Look out for:
Evidence
Strike question text
Small line
Typing with no selection
s3-ctrl-shift-s-collapsed-cursor.webm
Heading, list, undo and redo
s4-heading-list-strike-undo-redo.webm
Answers and hints
More captures (11)
AI usage
Claude Code traced the keymap conflict and wrote the fix and test; verified with the TipTapEditor Jest suite and pre-commit.
Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-10-25 02:56 UTC