Repository navigation
keybot: --clean on build commands clears the build caches - #118
Merged
Merged
Conversation
chrisnojima
force-pushed
the
nojima/HOTPOT-clean-caches
branch
from
October 14, 2026 17:39
0dc3672 to
de2e4a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
--cleantobuild darwin,build mobileandbuild android, which setsCLEAN_CACHES=1for the packaging scripts. The scripts then clear the yarn cache,node_modulesand the Go build cache instead of reusing them, for a from-scratch build. The client side is keybase/client#29764, which makes the release builds reuse those caches by default.build ios --cleanalready ranxcodebuild clean(CLEAN). It now also setsCLEAN_CACHES.--clean, every build command sendsCLEAN_CACHES=0, which the scripts treat as unset.build mobile --cleansets onlyCLEAN_CACHES, notCLEAN, so it doesn't add anxcodebuild clean.CLEAN_CACHES, so this can merge first.Testing
TestBuildCleanSetsCleanCaches: for each of the four build commands,CLEAN_CACHESis0without--cleanand1with it. It fails if the darwin wiring is removed.go test ./...passes, andgofmtandgolangci-lintare clean.