Skip to content

keybot: --clean on build commands clears the build caches - #118

Merged
chrisnojima merged 1 commit into
masterfrom
nojima/HOTPOT-clean-caches
Oct 14, 2026
Merged

chrisnojima merged 1 commit into
masterfrom
nojima/HOTPOT-clean-caches

Conversation

@chrisnojima

Copy link
Copy Markdown
Contributor

What

Adds --clean to build darwin, build mobile and build android, which sets CLEAN_CACHES=1 for the packaging scripts. The scripts then clear the yarn cache, node_modules and the Go build cache instead of reusing them, for a from-scratch build. The client side is keybase/client#29764, which makes the release builds reuse those caches by default.

Testing

  • New TestBuildCleanSetsCleanCaches: for each of the four build commands, CLEAN_CACHES is 0 without --clean and 1 with it. It fails if the darwin wiring is removed.
  • go test ./... passes, and gofmt and golangci-lint are clean.

@chrisnojima
chrisnojima force-pushed the nojima/HOTPOT-clean-caches branch from 0dc3672 to de2e4a6 Compare October 14, 2026 17:39
@chrisnojima
chrisnojima merged commit db0f8a0 into master Oct 14, 2026
4 checks passed
@zoom-ua
zoom-ua deleted the nojima/HOTPOT-clean-caches branch October 15, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant