Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
x_toleranceandy_tolerancediffer, changing the output render direction can merge separate source lines inutils.extract_textand in extracted table cells. For example, two source lines containing A and B should render as AB withline_dir_render="ltr", char_dir_render="ttb"; the current code instead returns "A\n \nB" because it switches from the source y tolerance to the render x tolerance.Select the clustering tolerance from
extractor.line_dir, matching the coordinate key used to group words. Rendering then changes the output direction without changing which source lines are grouped. This is a one-line production fix with no new parameters or dependencies.Tests cover all four source line directions and all eight render direction combinations, plus public
Page.extract_table()extraction using the existingline-char-render-example.pdffixture. Changelog and contributor credit are included.Validation on Windows, CPython 3.12.10:
git diff --checkpass.python setup.py build sdistpasses.The full suite has not been verified on Linux or on the other supported Python versions.
AI assistance was used to prepare this change and its regression tests.