Repository navigation
Avoid changing the host process arguments when importing the CLI - #1430
Open
justavibedev wants to merge 1 commit into
Open
justavibedev wants to merge 1 commit into
justavibedev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
pdfplumber.cliin a Python process with no command-line arguments adds--helpto the host program'ssys.argv. If the host parses its own arguments afterward, it can print help and exit before doing any work.This moves the no-argument help behavior into
main()and reads the arguments at call time. The regression test imports the CLI in a fresh Python process. It failed on develop; all 17 tests intests/test_convert.pypassed after the fix, including the existing no-argument help test.Codex assisted with the implementation and offline testing.