Skip to content

Fix licensing of github.com/kr/logfmt - #6142

Open
wojnilowicz wants to merge 1 commit into
jesseduffield:masterfrom
wojnilowicz:fix-licensing-of-kr-logfmt
Open

wojnilowicz wants to merge 1 commit into
jesseduffield:masterfrom
wojnilowicz:fix-licensing-of-kr-logfmt

Conversation

@wojnilowicz

Copy link
Copy Markdown

Requires only one commit up from logfmt in order to include its license file. This will make less troubles when trying to officially packaging it in Fedora.

PR Description

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Requires only one commit up from logfmt in order to include its license file.
This will make less troubles when trying to officially packaging it in Fedora.
@stefanhaller

Copy link
Copy Markdown
Collaborator

Looks reasonable, thanks. I'm on vacation right now, I'll have a closer look when I'm back home in two weeks. Please ping me if I forget.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants