Skip to content

control plane: retiring a workload does not end its established connections to peers #251

Open

Description

@avi-papineni

What happens

Retiring a workload removes its addresses from every peer set, so it can open no new connection to an enforced peer. Connections it already had open stay open.

The enforcement chain accepts established and related traffic before it evaluates any rule (ADR-0020, decision 3). A peer that leaves a rule's set is therefore refused only on its next new connection. The same is true of any peer removed from a set for any reason: a label change, an edited rule, an address change.

ADR-0023 describes retirement as the way to lock out an enrolled workload. It does not say that existing connections survive.

Expected

Either the record states this limit plainly, or removal from a peer set also ends the removed address's tracked connections on the rules that admitted them, without touching connections from other peers on the same rule.

Notes

  • The second option needs deletion scoped by original source address and the rule's connection mark together. Deleting by mark alone would end other peers' sessions.
  • Covers TCP, UDP and IPv6.
  • Until this is fixed, docs/ and ADR-0023 should say that retirement stops new connections only.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions