Skip to content

Enhance README with Three.js and React Three Fiber badges - #59

Merged
hoangsonww merged 3 commits into
masterfrom
fix/enhance-badges
Jun 12, 2026
Merged

hoangsonww merged 3 commits into
masterfrom
fix/enhance-badges

Conversation

@hoangsonww

Copy link
Copy Markdown
Owner

Added badges for Three.js and React Three Fiber to the README. Updated the landing page description to highlight the use of Three.js and React Three Fiber for improved UX.

Added badges for Three.js and React Three Fiber to the README. Updated the landing page description to highlight the use of Three.js and React Three Fiber for improved UX.

Signed-off-by: dav nguyxn <hoangson091104@gmail.com>
@hoangsonww hoangsonww added this to the v2.x.x - Stable Release milestone Jun 12, 2026
@hoangsonww hoangsonww self-assigned this Jun 12, 2026
@hoangsonww hoangsonww added the documentation Improvements or additions to documentation label Jun 12, 2026
Copilot AI review requested due to automatic review settings June 12, 2026 00:58
@hoangsonww hoangsonww added duplicate This issue or pull request already exists enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 12, 2026
@netlify

netlify Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for employee-management-fullstack-system canceled.

Name Link
🔨 Latest commit 1af522f
🔍 Latest deploy log https://app.netlify.com/projects/employee-management-fullstack-system/deploys/6a2b5a965a94710008a9d02b

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
employee-management-fullstack-app Ignored Ignored Jun 12, 2026 1:02am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to document the integration of Three.js and React Three Fiber into the landing page, including adding technology badges. The review feedback suggests correcting the React Three Fiber badge to use the React logo instead of the ReactOS logo, and formatting 'React Three Fiber' with backticks for consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md
![React Router](https://img.shields.io/badge/React%20Router-CA4245?style=for-the-badge&logo=reactrouter&logoColor=white)
![Redux](https://img.shields.io/badge/Redux-764ABC?style=for-the-badge&logo=redux&logoColor=white)
![Three.js](https://img.shields.io/badge/Three.js-000000?style=for-the-badge&logo=threedotjs&logoColor=white)
![React Three Fiber](https://img.shields.io/badge/React%20Three%20Fiber-000000?style=for-the-badge&logo=reactos&logoColor=61DAFB)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The badge for React Three Fiber uses logo=reactos, which displays the logo for the ReactOS operating system. Since React Three Fiber is a React-based library, it is more appropriate to use the React logo (logo=react) instead.

Suggested change
![React Three Fiber](https://img.shields.io/badge/React%20Three%20Fiber-000000?style=for-the-badge&logo=reactos&logoColor=61DAFB)
![React Three Fiber](https://img.shields.io/badge/React%20Three%20Fiber-000000?style=for-the-badge&logo=react&logoColor=61DAFB)

Comment thread README.md
The frontend is also live at [https://employee-manage-app.vercel.app](https://employee-manage-app.vercel.app) for you to explore and interact with the application. Note that the backend is not hosted, so the API calls will not work and the data will not be present.

**Landing Page:**
**Landing Page:** Polished with `Three.js` and React Three Fiber for a great UX and 3D experience

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency in formatting, both Three.js and React Three Fiber should be enclosed in backticks, or neither should be. Enclosing both in backticks is preferred to highlight them as technologies.

Suggested change
**Landing Page:** Polished with `Three.js` and React Three Fiber for a great UX and 3D experience
**Landing Page:** Polished with `Three.js` and `React Three Fiber` for a great UX and 3D experience

Updated the architecture documentation to reflect the polished landing page with 3D components using Three.js and React Three Fiber.

Signed-off-by: dav nguyxn <hoangson091104@gmail.com>
Signed-off-by: dav nguyxn <hoangson091104@gmail.com>
@hoangsonww
hoangsonww merged commit 7ae32e4 into master Jun 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants