Skip to content

refactor(base): add useoverride and reference client - #1529

Open
wneessen wants to merge 1 commit into
hetznercloud:mainfrom
wneessen:base-changes
Open

wneessen wants to merge 1 commit into
hetznercloud:mainfrom
wneessen:base-changes

Conversation

@wneessen

@wneessen wneessen commented Nov 3, 2026

Copy link
Copy Markdown
  • Add a UseOverride type to the ListCmd struct to allow to override the default "list" use.
  • Reference the Client in AdditionalFlags so additional flag functions can make use of it.

- Add a `UseOverride` type to the ListCmd struct to allow
  to override the default "list" use.
- Reference the `Client` in `AdditionalFlags` so additional
  flag functions can make use of it.
@wneessen
wneessen requested a review from a team as a code owner November 3, 2026 14:00
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.48%. Comparing base (df50db3) to head (68b6c9d).

Files with missing lines Patch % Lines
internal/cmd/base/list.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   79.76%   75.48%   -4.28%     
==========================================
  Files         303      303              
  Lines        9590     9593       +3     
==========================================
- Hits         7649     7241     -408     
- Misses       1941     2352     +411     
Flag Coverage Δ
e2e ?
unit 75.48% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 changed the title feat(base): add useoverride and reference client refactor(base): add useoverride and reference client Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant