Repository navigation
Minor fixes for alignment - #944
Merged
Merged
Conversation
… read value classes from the value tag - J1: processTagClasses drops a unitClass or valueClass name the schema does not define, as hed-typescript does, so the guards for undefined entries in ParsedHedTag.valueAsDefaultUnit and SchemaValueTag.equivalent are gone. - J2: attribute values of two declarations are compared item by item after sorting (SchemaEntryWithAttributes.sameValues), so ["a|b", "c"] no longer matches ["a", "b|c"]; the unit and value class names of value tags use the same comparison. New test in tests/otherTests/schemaParser.spec.js. - J3: value validation reads the value tag's valueClasses objects instead of the raw valueClass attribute, which is now removed from the tag's value attributes like unitClass. - CHANGELOG: entries for the three changes, and blank lines so the file passes prettier. npm test 920 -> 921 passed; testSpecs unchanged (1290 passed, 1 skipped); hed-web smoke check RESULT: PASS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven messages opened a double quote before a placeholder and never closed it (deprecated and duplicate tags, the Definition and Def-expand group-structure and forbidden-tag messages, invalidNumberOfSubgroups), or closed it with a single quote (conflictingDefinitions). Only the quotes change; the wording is kept. Raised by the Copilot review of hed-typescript PR #243. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Small alignment corrections in various places
0 new issues
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| const valueClassNames = valueClasses.map((valueClass) => valueClass.name) | ||
| return { | ||
| msg: `Tag "${this.schemaTag.name}" has value classes [${valueClassNames.join(', ')}] but its value "${value}" is not in any of them.`, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.