Repository navigation
Continue to realign with version 4.0.0 of HED specification - #937
Merged
Merged
Conversation
The letter test of specification 3.2.5 rule 6 keyed the Unicode form on
the literal character set name nonascii, so a schema whose nameClass
declaration allows non-ASCII through the composite set name or a literal
character (honored from HED 8.5.0) would reject an extension such as
Item/ete with accents. Test /\p{L}/u for every schema: a name class
without non-ASCII characters has already rejected them, so the result on
every shipped schema is unchanged (Copilot review of PR hed-standard#936).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…into realign_phase_3
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The preceding name-class validation preserves schema restrictions, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
This PR simplifies tag-extension validation as part of alignment with HED specification 4.0.0.
Changes:
- Uses a Unicode letter check for all schemas after name-class validation.
- Clarifies why schemas that disallow non-ASCII characters retain their existing restrictions.
| File | Description |
|---|---|
src/parser/tagConverter.js |
Simplifies the letter check and documents how name-class validation preserves schema restrictions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.