Repository navigation
Conversation
Aster89
marked this pull request as draft
September 7, 2026 18:02
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
September 30, 2026 09:08
a552f53 to
cca05a6
Compare
Aster89
marked this pull request as ready for review
September 30, 2026 09:10
Aster89
marked this pull request as draft
September 30, 2026 09:21
Aster89
added
the
status: blocked
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
October 9, 2026 08:02
cca05a6 to
a6f5b54
Compare
Aster89
marked this pull request as ready for review
October 9, 2026 08:03
Aster89
removed
the
status: blocked
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
October 10, 2026 08:21
7bc0e8d to
c9816dd
Compare
Collaborator
Author
|
The breakage is uniquely due to the new version of Looking into it 😄 Oh, well, things seem to be easier than I thought, according to what @simonhorlick wrote in alanz/ghc-exactprint#156:
|
Collaborator
|
@Aster89 hey, I'm sorry I'll raise a PR for this now. |
Collaborator
1 task done
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
October 12, 2026 11:43
c9816dd to
1efd70c
Compare
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
October 13, 2026 16:16
04a41af to
97a5b0d
Compare
ghc-exactprint >= 1.14.3 sets a layout column at the first constructor, so the ones after it take a zero column delta instead of two.
Slight simplification
Aster89
force-pushed
the
move-appendMissingPatterns-to-ghc-exactprint
branch
from
October 13, 2026 17:02
97a5b0d to
1f7a55c
Compare
Aster89
commented
Oct 14, 2026
Aster89
added
the
component: hls-case-split-plugin
fendor
approved these changes
Oct 14, 2026
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, merge when you are ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested against alanz/ghc-exactprint#148 locally on my machine. It builds and case-split plugin's tests pass.
This PR is a draft because alanz/ghc-exactprint#148 needs to be merged in first.
Fix #5077
This PR includes a commit authored by @simonhorlick and generated with Claude Code's assistance.
I've added a fixup commit to remove some (seemingly, according to the tests) redundant code.