Repository navigation
Conversation
The speaker view clock was hardcoded to the 'en-US' locale with hour12: true, always showing a 12-hour AM/PM clock regardless of the user's system settings. This forces a 24-hour format preference (the default in most non-US locales) into 12-hour display. Pass navigator.language instead of a fixed locale and drop the hour12 override, so toLocaleTimeString() falls back to the hour cycle the user's browser/OS already uses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speaker view clock (plugin/notes/speaker-view.html) hardcodes toLocaleTimeString('en-US', { hour12: true, ... }), so it always renders a 12-hour clock regardless of the presenter's browser/OS locale — even for locales where 24-hour time is the norm.
This PR passes navigator.language instead of a fixed locale and drops the hour12 override, so the clock respects whatever hour cycle the user's system already uses.