Repository navigation
Add Yeeter privacy deletion and export endpoints - #1766
Merged
Merged
Conversation
Implement the hackatime audience, database replay receipts and transactional erasure with rollback previews. Preserve detached shared records, remove attributable files and document external retention boundaries. Co-authored-by: Echo <github@3kh0.net>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
[Critical impact] The PR appears safe to merge, with a non-blocking request to restore the privacy operator guide. SummaryAdds signed privacy deletion and count-only export endpoints.
Both earlier, unnumbered findings are addressed: history matching now checks complete identifier values, and activity cache calculations share a lock with deletion. DiagramsequenceDiagram
participant Y as Yeeter
participant A as Privacy API
participant D as Database
participant S as Files and cache
Y->>A: Signed delete or export request
A->>A: Verify signature and claims
A->>D: Consume replay receipt
A->>D: Find matching records
alt Export
A-->>Y: Held record counts
else Deletion preview
A->>D: Erase records, then roll back
A-->>Y: Preview counts
else Real deletion
A->>D: Erase records in transaction
A->>S: Remove files and clear cache
A->>D: Commit
A-->>Y: Deleted and retained counts
end
Reviews (3) · Last reviewed commit: "Delete docs/privacy.md" · Reviewed by Greptile |
Co-authored-by: Echo <github@3kh0.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Hackatime needs to handle centrally signed privacy requests without exposing personal identifiers or changing account data during previews.
Describe your changes
hackatimeaudience, with database-backed replay protection.docs/privacy.md.Screenshots / Media
Synthetic development accounts only.
Audit records before and after detaching an actor
Ordinary actor:
Detached actor:
Both states in the audit list: