Repository navigation
Restore a minimum of 64 for Error.stackTraceLimit - #10430
Merged
Merged
Conversation
Other browsers with higher limits now can keep those, and specifying a value of 0 will compile out this check entirely. Fixes gwtproject#10429
jnehlmeier
reviewed
Nov 4, 2026
| 0 will result in compiling out the check entirely. | ||
| --> | ||
| <define-configuration-property name="gwt.error.stackTraceLimit" is-multi-valued="false" /> | ||
| <set-configuration-property name="gwt.error.stackTraceLimit" value="0" /> |
Member
There was a problem hiding this comment.
To keep the old behavior it should be 64 and not 0.
Member
Author
There was a problem hiding this comment.
Whoops! I tweaked it to test one more time in each browser (and in output) before committing and forgot to revert, thank you
jnehlmeier
previously approved these changes
Nov 5, 2026
zbynek
added
the
ready
zbynek
reviewed
Nov 5, 2026
zbynek
approved these changes
Nov 5, 2026
zbynek
left a comment
zbynek
left a comment
Collaborator
There was a problem hiding this comment.
(Approved assuming CI passes.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other browsers with higher limits now can keep those, and specifying a value of 0 will compile out this check entirely.
Fixes #10429
Regression from #10185