Repository navigation
refactor(py/handlebars)!: stop exporting parsed-template classes - #638
Open
huangjeff5 wants to merge 2 commits into
Open
huangjeff5 wants to merge 2 commits into
huangjeff5 wants to merge 2 commits into
Conversation
huangjeff5
force-pushed
the
jeff/hb-private-ast
branch
from
November 11, 2026 16:51
ee547c4 to
e1595f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotpromptz_handlebarsexported the scanner token and AST classes its parser builds internally. No public method, attribute, callback, or exception accepts or returns them, so they're no longer importable fromdotpromptz_handlebarsorhandlebarrz.Decisions
Block,ElseNode,InlinePartial,Mustache,Node,Partial,PartialBlock,Program,TagToken,Text) appear in any public parameter, return type, attribute, or callback.Handlebars.compile()closes over the parsedPrograminternally and returnsCallable[..., str],Handlebars.register_template()returnsNoneand storeslist[Node]on private_templates, andHandlebarsexposes noparse()or AST visitor API (matching legacyhandlebarrz0.1.9).Handlebars,EscapeFunction), custom helpers (HelperFn,HelperOptions,BlockFn,SafeString,Context,ContextDict), render calls (RuntimeOptions), andtry/exceptblocks (StrictModeError,TemplateRecursionError).Mustache.call: dict[str, Any],ElseNodeas a pre-fold marker,TagTokenscanner flags) that should stay free to change internally.dotpromptz: Every symbol imported bydotpromptz0.1.6 and 0.2.0 still resolves from bothdotpromptz_handlebarsandhandlebarrz.