Repository navigation
fix(py/handlebars): keep spaces between tags that share a line - #637
Open
huangjeff5 wants to merge 2 commits into
Open
huangjeff5 wants to merge 2 commits into
huangjeff5 wants to merge 2 commits into
Conversation
huangjeff5
force-pushed
the
jeff/hb-inline-space
branch
from
November 11, 2026 16:51
857b9b3 to
2893cef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A block, partial, or comment tag at the start of a line dropped the spaces between it and the next tag on that line, so words in a rendered prompt ran together. Handlebars.js keeps those spaces, and now this engine does too.
Decisions
{{#if}},{{#each}},{{else}}, closing tags,{{> partial}}, and{{! comment}}, since they all follow the same line rule.Verification
handlebars@4.7.9: all 8 new cases ({{#each}},{{#if}},{{else}}, closing tags,{{> partial}},{{! comment}}, and trailing spaces after a standalone closing tag at EOF) live inpython/handlebars/tests/conformance_cases.json, whichtest_recorded_output_still_matches_handlebars_4_7_9re-renders through Node viaconformance_oracle.jsin CI.