Repository navigation
Lock zip 0.6.6 in netsim Cargo.lock - #3369
Merged
Merged
Conversation
crates.io yanked zip 0.6.4 through 0.6.6, causing fresh Cargo resolution for netsim-common (which requires zip ^0.6.4) to fail during Bazel module extension evaluation. Supply a Cargo.lock pinning zip 0.6.6 and its direct dependencies so Cargo continues to resolve the already-locked version. Assisted-by: Jetski:Gemini
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a patch to lock the zip crate version to 0.6.6 by adding a Cargo.lock file and configuring Bazel to use it. However, the provided Cargo.lock is incomplete as it only defines a subset of the workspace's dependencies. This can lead to build failures in sandboxed or offline Bazel environments. It is recommended to generate and use a complete lockfile representing the entire dependency graph.
ser-io
self-requested a review
October 16, 2026 14:36
ser-io
approved these changes
Oct 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates.io yanked
zip0.6.4through0.6.6, causing fresh Cargo resolution fornetsim-common(which requireszip = "^0.6.4") to fail during Bazel module extension evaluation:Supply a
Cargo.lockpinningzip 0.6.6and its direct dependencies viacargo_lockfile = "@android_tools_netsim//:rust/Cargo.lock"so Cargo continues to use the already-locked version.