Skip to content

fix(integrations): honor shared refresh for installed targets - #5377

Open
WOLIKIMCHENG wants to merge 1 commit into
github:mainfrom
WOLIKIMCHENG:fix/switch-refresh-installed-targets
Open

WOLIKIMCHENG wants to merge 1 commit into
github:mainfrom
WOLIKIMCHENG:fix/switch-refresh-installed-targets

Conversation

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor

Description

Honor integration switch --refresh-shared-infra for installed targets, including the current default, through the existing shared installer. This refreshes customized shared scripts, page templates, and .specify/.gitignore while preserving separate teardown consent and the current-default no-flag no-op.

Testing

  • Real CLI matrix: 2 failed/10 passed before the fix; 12 passed afterward.
  • 413 focused tests passed on Linux/Python 3.11; Ruff 0.15.0 and whitespace checks passed.
  • Full suite: 15,879 passed, 591 skipped, 8 host-sensitive failures involving Git author configuration and root permissions. Native Windows/macOS and Markdownlint were not run locally.

Manual test results

Agent: Codex following the generated skill | OS/Shell: Linux/Bash

Command tested Notes
/speckit-specify After installed-target refresh, the generated Claude skill's Bash resolver ran and the spec, 16-item checklist, and feature state were completed. No hooks were registered.

AI Disclosure

  • I did use AI assistance (described below)

AI disclosure: AI-assisted tools were used to implement the fix and develop tests.

Assisted-by: Codex (model: gpt-6.1-sol, autonomous)
@WOLIKIMCHENG
WOLIKIMCHENG requested a review from mnriem as a code owner November 11, 2026 04:22
Copilot AI auto review requested due to automatic review settings November 11, 2026 04:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The shared-infrastructure refresh changes have no active review issues.

No open issues 🎉

What changed in this PR

Fixes Specify CLI’s integration switch --refresh-shared-infra handling for installed targets, including the current default, using the existing shared installer.

Changes:

  • Honors explicit shared refresh while preserving separate teardown consent and the current-default no-flag no-op.
  • Expands regression coverage for flag combinations, stored runtimes, manifest integrity, failure handling, and file protections.
  • Documents refresh behavior for new, installed, and current-default targets.
File Description
tests/​specify_cli/​integrations/​test_command_switch.py Expands refresh regression tests and preservation checks.
src/​specify_cli/​integrations/​command_switch.py Honors the refresh flag for installed targets and updates CLI help.
docs/​integrations/​cli.md Clarifies overwrite consent and current-default behavior.

Review effort: Balanced (auto)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants