Skip to content

test: make script help assertion resilient to wrapping - #5347

Merged
mnriem merged 1 commit into
github:mainfrom
mnriem:mnriem-ci-failure-fix
Nov 9, 2026
Merged

mnriem merged 1 commit into
github:mainfrom
mnriem:mnriem-ci-failure-fix

Conversation

@mnriem

@mnriem mnriem commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Make the script-help assertion independent of Rich table borders when help text wraps across lines. Cover terminal widths of 60, 80, and 120 columns for init and integration install, switch, and upgrade. CLI behavior is unchanged.

Testing

Set up this checkout's .venv and editable install using the local development guide. Run commands from the checkout root.

  • Tested locally with .venv/bin/specify --help (Windows PowerShell: .\.venv\Scripts\specify.exe --help)
  • Ran relevant existing tests with .venv/bin/python -m pytest tests -q (Windows PowerShell: .\.venv\Scripts\python.exe -m pytest tests -q); use affected test paths for focused checks and LC_ALL=en_US.UTF-8 on macOS
  • Tested with a sample project (if applicable)

Commands and results:

  • .venv/bin/specify --help - passed.
  • .venv/bin/python -m pytest tests/specify_cli/integrations/test_registration.py -q - 21 passed.
  • GITHUB_ACTIONS=true .venv/bin/python -m pytest tests/specify_cli/integrations/test_registration.py -q - 21 passed.

The full suite and Windows runner were not run locally. A sample project is not applicable to this test-only change.

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (fill in the disclosure below)

AI disclosure: GitHub Copilot using GPT-6.1 Sol (model ID: gpt-6.1-sol), autonomous agent mode with runtime-default reasoning settings, assessed the CI failure, authored the test changes and this PR description, ran the focused checks, and committed and pushed the fix on behalf of @mnriem.

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI auto review requested due to automatic review settings November 9, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active issues were identified, and the changes are narrowly focused on making script-help regression tests reliable across terminal widths without changing CLI behavior.

No open issues 🎉

What changed in this PR

Updates the script-help regression tests to remain reliable when Rich wraps output at different terminal widths, without changing CLI behavior.

Changes:

  • Parameterizes help checks for terminal widths of 60, 80, and 120 columns.
  • Normalizes Rich table separators before matching wrapped help text.
  • Covers init, integration install, integration switch, and integration upgrade.
File Description
tests/​specify_cli/​integrations/​test_registration.py Expands script-help coverage across terminal widths and normalizes Rich table output before assertions.

This pull request is ready to be approved.

Review effort: Lite (auto)

@mnriem
mnriem merged commit e61545c into github:main Nov 9, 2026
16 checks passed
@mnriem
mnriem deleted the mnriem-ci-failure-fix branch November 9, 2026 20:28
kevinnguyenhoang91 pushed a commit to kevinnguyenhoang91/spec-kit that referenced this pull request Nov 10, 2026
Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants