[Yi-111-a]

Description

Fix: preserve existing priority from registry when installing/refreshing bundles

When bundle install --refresh or bundle update is run, the
existing user-set priorities (via specify preset set-priority /
specify extension set-priority) were being reset to the bundle's
declared priority. This fix reads the existing priority from the
registry first, and only falls back to the component's declared
priority or DEFAULT_PRIORITY if no existing priority is found.

Testing

Manual testing showed that running bundle install --refresh after
setting a priority via specify extension set-priority now preserves
the user-set priority instead of resetting it to 10.

See the commit for details: fix/bundle-priority-preservation

[Copilot]

🟡 Changes recommended

Singular component-kind checks skip registry lookups for presets and extensions, so refresh still overwrites saved priorities, with no regression tests covering preservation.

3 open issues

• Use the plural preset kind to preserve registry priority · New
• Use the plural extension kind to preserve registry priority · New
• Add regression tests for priority preservation and fallback · New

What changed in this PR

This PR aims to preserve user-set preset and extension priorities when Specify CLI installs or refreshes bundles.

Changes:

• Adds registry-priority lookups to both component installers.
• Falls back to the bundle-declared priority or DEFAULT_PRIORITY when no saved priority exists.

Project tests were not run in this review environment.

AI-generated review by GitHub Copilot (model: unknown; automated mode) for the requesting contributor; analysis and wording are AI-generated.

File	Description
src/​specify_cli/​bundles/​primitives.py	Adds saved-priority selection for preset and extension installation paths.

_{Review effort: Balanced (auto)}

[mnriem]

Please address Copilot feedback

[Yi-111-a]

Thanks — addressed the Copilot feedback in 60a3a1b:

• The registry lookups now compare against the real plural kinds ("presets" / "extensions"), so a saved priority is actually read on install and refresh.
• Added regression tests for both managers: a registry priority (37) survives install/refresh even when the bundle declares a different one, and without a saved priority we fall back to the declared value or DEFAULT_PRIORITY. The preservation tests fail on the previous commit and pass now.
• Gave the existing _FakeManager test doubles an empty registry so they keep exercising the same paths.

pytest tests/specify_cli/bundles passes locally (1280 passed).

[Copilot]

🟡 Changes recommended

Unnormalized registry priorities can cause refresh/update failures for stored string or zero values, requiring normalization and a declared/default fallback in both bundle and extension paths.

1 open issue

• Normalize registry priorities before bundle refresh · New

3 resolved since last review

• Use the plural extension kind to preserve registry priority
• Use the plural preset kind to preserve registry priority
• Add regression tests for priority preservation and fallback

_{Review effort: Balanced (auto)}

[mnriem]

Please address Copilot feedback

[Yi-111-a]

Thanks — addressed the second Copilot review in e83e024:

• Stored registry priorities are now passed through normalize_priority in both the preset and extension paths, falling back to the declared priority (or DEFAULT_PRIORITY) when the saved value is a non-numeric string, zero, or a boolean. A numeric string like "37" is still honored as 37.
• Added regression tests for both managers covering "37", "high", 0 and True; all 8 cases fail on the previous commit and pass now (tests/specify_cli/bundles/test_primitives.py: 109 passed).

[Copilot]

🟢 Approval recommended

No active review issues are reported for the priority-preservation change, although tests were not executed.

No open issues 🎉

1 resolved since last review

• Normalize registry priorities before bundle refresh

_{Review effort: Balanced (auto)}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the changes preserving registry-stored preset and extension priorities.

No open issues 🎉

_{Review effort: Balanced (auto)}

[mnriem]

Thank you!