Repository navigation
[FE] Slack 에러 웹훅을 서버 라우트로 이동 - #406
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sumi-0011
force-pushed
the
issue-505-get-10-pets
branch
from
September 2, 2026 02:33
5394d59 to
7274d75
Compare
sumi-0011
force-pushed
the
fix/slack-error-token-leak
branch
2 times, most recently
from
September 2, 2026 02:36
6756925 to
d553b52
Compare
웹훅 URL 이 NEXT_PUBLIC_ 이라 브라우저 번들에 실려 있었다. 누구나 그 채널에 쓸 수 있는 상태였다. - 웹훅 호출을 /api/slack/error 서버 라우트로 이동 - SLACK_ERROR_CHANNEL_WEBHOOK_URL 로 이름 변경 (NEXT_PUBLIC_ 제거) - 브라우저가 보내는 값이라 라우트에서 타입·공백·길이(4000자) 검사 - 가챠 실패 리포트에서 <!here> 제거. 실패율이 높은 구간에 채널 전체 핑이 되어 에러 채널을 뮤트하게 만든다. 전역 에러/not-found 는 유지 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LEU7s7NYEZXX6dmjBEuUy6
sumi-0011
force-pushed
the
fix/slack-error-token-leak
branch
from
September 2, 2026 07:47
d553b52 to
c3cef22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 작업 내용
에러 채널 웹훅 URL 이 브라우저 번들에서 사라집니다. 알림은
/api/slack/error서버 라우트를 거칩니다. 호출부 6곳은 그대로입니다.NEXT_PUBLIC_SLACK_ERROR_CHANNEL_WEBHOOK_URL→SLACK_ERROR_CHANNEL_WEBHOOK_URL<!here>를 뺐습니다./gotchas가 42% 실패 중이라([BE] /gotchas 전 요청 500 — UN HANDLED EXCEPTION gitanimals#507) 채널 전체 핑이 계속 울려 정작 장애 중에 에러 채널을 뮤트하게 만듭니다. 전역 에러·not-found 는 그대로 둡니다.accessToken 제거는 #407 에서 이미 처리돼 이 PR에서 뺐습니다.
not-found.tsx가 비로그인 방문자에게도 알림을 보내서, 인증을 걸면 그 경로가 죽습니다. 대신 길이 상한만 뒀습니다 — 이 선택이 맞는지 봐주세요.검증:
type-check,vitest run(26 passed, 라우트 4건 신규),pnpm build:web통과. 빌드 결과에/api/slack/error등록 확인.🤖 Generated with Claude Code