Repository navigation
secretservice: use the correct MIME content type - #2475
Merged
Merged
Conversation
Secret Service backends that validate MIME content types, such as oo7-daemon on Fedora 45, reject credential writes with 'Invalid content type: plain/text'. Authentication succeeds, but the credential is never stored and subsequent Git operations prompt again. Use the standard text/plain content type for secret values so these backends can store credentials. Existing credentials remain readable because lookups use the service and account attributes, and GCM reads the secret bytes without checking the content type. Only new or updated secrets get the corrected content type; no migration of existing entries is needed. Assisted-by: GPT-6.1 Sol Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secret Service backends that validate MIME content types, such as oo7-daemon on Fedora 45, reject credential writes with 'Invalid content type: plain/text'. Authentication succeeds, but the credential is never stored and subsequent Git operations prompt again.
Use the standard text/plain content type for secret values so these backends can store credentials.
Existing credentials remain readable because lookups use the service and account attributes, and GCM reads the secret bytes without checking the content type. Only new or updated secrets get the corrected content type; no migration of existing entries is needed.
Fixes #2473