Repository navigation
Conversation
malept
force-pushed
the
malept-claude/yq-01-convert
branch
2 times, most recently
from
October 19, 2026 14:08
dd76639 to
ef518a5
Compare
|
Link to code coverage report (posted by coverbot 🤖) |
malept
changed the title
malept
force-pushed
the
malept-claude/yq-01-convert
branch
2 times, most recently
from
October 20, 2026 15:26
7ba4eea to
baf8599
Compare
malept
added this pull request to stack #1247
October 20, 2026 15:35
malept
marked this pull request as ready for review
October 21, 2026 01:02
malept
marked this pull request as draft
October 21, 2026 01:03
malept
marked this pull request as ready for review
October 21, 2026 01:03
iamrz1
approved these changes
Oct 21, 2026
Adds github.com/itchyny/go-yaml and internal/yq/yq.go, which decodes YAML into gojq's plain value shape while recording each decoded object's original key order for later key-order-preserving output. github.com/itchyny/gojq itself is added in a later commit, the first one that actually imports it: this commit only decodes YAML, so go mod tidy would otherwise strip gojq as unused. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6KZ8poDhgpwRBbP4VrvPe
malept
force-pushed
the
malept-claude/yq-01-convert
branch
from
October 21, 2026 16:32
baf8599 to
548237b
Compare
iamrz1
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds
github.com/itchyny/go-yamlas a new dependency, andinternal/yq/convert.go, which decodes YAML into gojq's plain value shape while recording each decoded object's original key order for later key-order-preserving output. Part of replacingshell/yq.sh's gojq/python-yq subprocess wrapper with adevbase yqGo subcommand (#1217).Notes for your reviewers
internal/yq/convert_test.gocovers decoding scalars, nested maps/sequences, and the key-order side-table this PR introduces for later use.github.com/itchyny/gojqis added in #1235, where it's actually imported; this PR only decodes YAML, andgo mod tidywould otherwise strip gojq as unused.Generated by Claude Code