Repository navigation
Conversation
ExecutionMode listed MANUAL, SCHEDULED and SYSTEM, but the admin proto also defines RELAUNCH, CHILD_WORKFLOW, RECOVERED and TRIGGER, so code checking a fetched execution for one of those modes raised AttributeError. Take every value from the generated proto, as WorkflowExecutionPhase does, and test against the proto enum. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
cosmicbboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
October 26, 2026 06:43
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
No tracking issue.
Why are the changes needed?
Relaunched executions deserialize into the SDK, but callers cannot identify them by name because ExecutionMode omits the service's RELAUNCH value:
What changes were proposed in this pull request?
Expose the execution modes from the generated admin proto while preserving the existing numeric values. The definition is in the admin proto.
How was this patch tested?
Testing Done
An admin protobuf for a relaunched execution goes through the SDK conversion used for fetched metadata. This validates that conversion and the named comparison, not a live service fetch.
Reproducer source: relaunch_mode.py
Before the change, the same conversion returned mode 3 but the named comparison raised the AttributeError above.
Setup process
Python 3.12 with the SDK development environment and this checkout on PYTHONPATH.
Screenshots
Not applicable.
Check all the applicable boxes
Related PRs
None.
Docs link
No separate documentation change.