Repository navigation
ci: start publishing @google-cloud/adapter-nextjs - #717
Merged
Merged
Conversation
Remove @google-cloud/adapter-nextjs from unreleasedPackages so that it gets canary and tagged releases through OSS Exit Gate like the other packages. The list stays, now empty, for the next package that needs CI before it ships.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the scripts/github.js file to remove @google-cloud/adapter-nextjs from the list of unreleased packages, indicating it is now ready for release. I have no further feedback to provide as there are no review comments or issues identified.
abhis3
marked this pull request as ready for review
November 11, 2026 19:36
abhis3
requested review from
Yuangwang,
annajowang,
falahat and
leoortizz
as code owners
November 11, 2026 19:36
Yuangwang
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
@google-cloud/adapter-nextjsfromunreleasedPackagesinscripts/github.js, so it gets canary and tagged releases like the other packages. Publishing goes through OSS Exit Gate only (#715), and the Exit Gate project config already lists this package.The
unreleasedPackageslist stays, now empty, for the next package that needs CI before it ships.What changes after this merges
mainthat touchpackages/@google-cloud/adapter-nextjspublish0.1.0-canary.<sha>with thecanarynpm tag, after the usualreleaseapproval.@google-cloud/adapter-nextjs-v0.1.0publishes0.1.0with thelatesttag. Scoped tags match only that package, and unscopedadapter-nextjs-v*tags still match only@apphosting/adapter-nextjs.publish-exit-gate.ymlruns can filter to this package.Nothing changes for the other packages.
Release order
npm points
latestat the first version a package ever publishes, whatever tag it's published with. So the first publish should be the0.1.0release, cut right after this merges and before any canary of this package is approved.Testing
Dry runs of
scripts/publish.js(PUBLISH_DRY_RUN=true) one3d37c4, before and after this change:mainthat changes the package (HEAD^1..HEADis #714)@google-cloud/adapter-nextjs@0.1.0-canary.e3d37c4, tagcanary@google-cloud/adapter-nextjs-v0.1.0lerna listfails (--scopeand--ignorecancel out)@google-cloud/adapter-nextjs@0.1.0, taglatestadapter-nextjs-v14.0.22@apphosting/adapter-nextjs@14.0.22package=@google-cloud/adapter-nextjslerna listfails0.1.0-canary.e3d37c4.<run_id>.<attempt>, tagcanarynpm pack --dry-runafternpm run buildgives 31 files (42.7 kB):README.md,package.jsonanddist/(includingdist/index.jsanddist/serve.js).npm run lint:quietpasses.