Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PydanticSettings is stored in a cdef object global, retaining BaseSettings outside the generated module's GC traversal and clearing. Objects reachable through that class can consequently survive interpreter teardown.
Store the imported class in the Python module dictionary so it remains available during normal execution and atexit callbacks, then participates in ordinary interpreter cleanup.
The regression test uses a synthetic settings class and finalization marker. It verifies that configuration providers work in exit callbacks registered before and after the providers import, and that the marker is subsequently finalized. It fails with the unchanged release and passes with this change on macOS and Linux using Python 3.13.
Validation: full upstream unit suite (1386 passed, 2 skipped), Pydantic 1 configuration suite (204 passed), and unchanged-versus-fixed Linux builds. Existing deprecation warnings remain visible.