[kleisauke]

No description provided.

[kleisauke]

This time we needed to do more than what was done previously in #28026 (comment), i.e.:

• Update tools/system_libs.py, as the mimalloc tree was reorganized via commit microsoft/mimalloc@f72b7a0 (dc59269).
• Backport PR prim.c: prefer Emscripten's implementation over WASI microsoft/mimalloc#1455 (dda5966).
• Revert commit microsoft/mimalloc@80d6e71 (e076497).
• Update the codesize expectations for both other.test_malloc_size_mimalloc and other.test_malloc_size_mimalloc_O2 (1775d44 and e136b40).
  • As possible follow-up, we could build with -DMI_PROFILE=0 -DMI_STATS=0 to avoid this.
• Print the enabled options in other.test_mimalloc_headers, handy for debugging (2da18e5, could potentially be split out, although it's very minor).

Tested with:

$ ./test/runner {core2,wasmfs,wasm64_4gb}.test_wrap_malloc_mimalloc other.test_malloc_size_mimalloc* other.test_malloc_multithreading_mimalloc* other.test_mimalloc_headers
Running 8 tests
Using 8 parallel test processes
[8/8] test_malloc_size_mimalloc_O2 (test_other.other.test_malloc_size_mimalloc_O2) ... ok

----------------------------------------------------------------------
Ran 8 tests in 1.141s

OK
Total core time: 4.017s. Wallclock time: 1.141s. Parallelization: 3.52x.

[gemini-code-assist]

Code Review

This pull request updates mimalloc to version 3.6.0, introducing a major refactoring of the internal headers and source files into structured subdirectories. Key enhancements include a new pprof-compatible heap profiler, support for quiescent state-based reclamation (QSBR), better cache-line-aware allocations, improved fork support, and various bug fixes. Regarding the feedback, a potential false positive was identified in the mismatched delete operator check within free.c for small allocations with large alignments; adding a check to ensure the page does not have interior pointers would resolve this issue.