Skip to content

Internalize the glimmer-vm repo - #20908

Merged
ef4 merged 5264 commits into
mainfrom
glimmervm-submodule
Jan 6, 2026
Merged

ef4 merged 5264 commits into
mainfrom
glimmervm-submodule

Conversation

@ef4

@ef4 ef4 commented May 6, 2025

Copy link
Copy Markdown
Contributor

This is a work-in-progress on harmonizing the glimmer-vm repo with this repo so they can eventually merge.

Update package meta post-publish and tell the auto-publish infra to do this for us
Re-enable CJS for @glimmer/compiler (used by babel plugin)
Rollup the types (solves missing types from unpublished packages)
…d-on-build-tools

Add README to @glimmer/interfaces to try to force a release of dependent packages
@ef4
ef4 marked this pull request as ready for review January 6, 2026 16:04
@ef4
ef4 merged commit 4abca82 into main Jan 6, 2026
29 checks passed
@ef4
ef4 deleted the glimmervm-submodule branch January 6, 2026 18:45
@sandstrom

Copy link
Copy Markdown
Contributor

Have you discussed merging more Ember repositories under the emberjs org?

Repos under orgs other than emberjs:

  • github.com/ember-cli
  • github.com/ember-learn
  • github.com/glimmerjs (now moved)
  • github.com/ember-fastboot (dead?)
  • github.com/ember-engines (dead?)
  • github.com/ember-template-lint
  • github.com/ember-codemods
  • github.com/ember-a11y
  • github.com/ember-modifier
  • github.com/embroider-build
  • github.com/ember-tooling
  • github.com/adopted-ember-addons
  • github.com/universal-ember

I would suggest something like:

  • emberjs org; Main org, which would include all official stuff (Ember CLI, Embroider, IDE tooling, etc).
  • ember-community org; An Ember core team controlled community org, where the org is managed by Ember, but each repo isn't. This is clearly stated. For example ember-a11y, ember-codemods and perhaps experiments like ember-engines and ember-fastboot (if they are still relevant) could live there. Things that aren't a good fit for adopted-ember-addons (I would also rename it to ember-adopted-addons for symmetry with other repo names).
  • ember-adopted-addons org; already a pretty good org scope, no change (but I would rename from adopted-ember-addons to ember-adopted-addons).

@kategengler

Copy link
Copy Markdown
Member

Hi @sandstrom. I appreciate your thoughts on this. We merged glimmer-vm in and later, router_js, for technical reasons more than any organizational reasons. glimmer-vm being part of the ember repo makes sense because it is (for the most part) only used by ember.js. When it was separate we suffered an integration step whenever we made changes in glimmer-vm.

router_js had a similar problem -- as we look towards making a Route Manager, we need to more easily be able to iterate between the two and the library deliniation was arbitrary.

We have a comprehensive list of orgs and repos but don't feel there needs to be a logical grouping in each github org. I am working on a tool to surface all the repos for discoverability purposes.

A primary reason we keep many orgs is github actions usage limits and concurrency.

I'd also like to correct: ember-engines and fastboot are official parts of Ember and not experiments. Engines was RFC'd. However, while supported by many people from Ember core, adopted-ember-addons is not owned by the ember project.

@sandstrom

Copy link
Copy Markdown
Contributor

Alright, I understand your point of view. Thanks for taking time answering 😀

Happy Easter! 🐣🐇

@github-actions github-actions Bot mentioned this pull request Oct 17, 2026
@NullVoxPopuli NullVoxPopuli changed the title Working toward glimmer-vm repo integration Internalize the glimmer-vm repo Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants