Skip to content

Fix standard_error() for skewness and kurtosis from datawizard - #1288

Open
jmgirard wants to merge 10 commits into
mainfrom
skewness-kurtosis-se
Open

jmgirard wants to merge 10 commits into
mainfrom
skewness-kurtosis-se

Conversation

@jmgirard

@jmgirard jmgirard commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

standard_error() returned NULL for objects from datawizard::skewness() and datawizard::kurtosis(), because it read an SE attribute while datawizard returns an SE column. It now reads the column, and falls back to the attribute for older objects. It also adds methods for the new datawizard_skewness and datawizard_kurtosis classes (easystats/datawizard#715).

standard_error(datawizard::skewness(mtcars$mpg))
#> [1] 0.394771

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Bootstrap tests should skip when the optional boot package is unavailable.

1 open issue
What changed in this PR

Updates standard_error() to support current and legacy datawizard skewness and kurtosis outputs.

Changes:

  • Reads SE columns with legacy attribute fallback.
  • Adds methods for new datawizard_* classes.
  • Adds tests, NEWS documentation, namespace registrations, and a version bump.
File Summary
tests/​testthat/​test-skewness_kurtosis.R Tests supported inputs, classes, and attribute forms.
R/​methods_skewness_kurtosis.R Implements standard-error extraction.
NEWS.md Documents the fix.
NAMESPACE Registers new S3 methods.
DESCRIPTION Increments the development version.

Review effort: Lite

Comment thread tests/testthat/test-skewness_kurtosis.R
@jmgirard

Copy link
Copy Markdown
Contributor Author

#1288 (review)

  • tests/testthat/test-skewness_kurtosis.R:1 (skip the bootstrap test without boot): fixed in 947a012.

@jmgirard jmgirard changed the title Return standard errors of skewness and kurtosis output from datawizard Fix standard_error() for skewness and kurtosis from datawizard Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants