Repository navigation
Fix build warnings from clang - #282
Merged
Merged
Conversation
token pasting of ',' and __VA_ARGS__ is a GNU extension that clang warns about with -Wgnu-zero-variadic-macro-arguments that is on by default.
Supported versions of C require a prototype.
bbiiggppiigg
requested changes
Oct 17, 2026
bbiiggppiigg
left a comment
bbiiggppiigg
left a comment
Member
There was a problem hiding this comment.
The resumeLog issue seems real.
The null check might be worth having.
The rest are probably fine?
bbiiggppiigg
requested changes
Oct 17, 2026
kupsch
approved these changes
Oct 17, 2026
hainest
added a commit
to dyninst/dyninst
that referenced
this pull request
Nov 4, 2026
It now builds cleanly as of dyninst/testsuite#282.
hainest
added a commit
to dyninst/dyninst
that referenced
this pull request
Nov 8, 2026
It now builds cleanly as of dyninst/testsuite#282.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.