[hainest]

Static rewriting isn't supported on aarch64.

[hainest]

@kupsch It was failing because rewriting statically-linked binaries isn't supported on aarch64.

[hainest]

Working correctly on grace-hopper and grace machines at UO.

[kupsch]

Looks good. Two optional things:

1. It would be nice have the test use SKIPPED with a message instead of silently be not run so it is visible. That's what I did in on the branch kupsch/filter-DSOs-to-parse.

2. Also the AI suggests: The cleaner fix is to make DYNINST_ENABLE_STATIC_TESTS default to OFF when the target is aarch64. That keeps one control point users can override, and it also covers any future static tests added in other directories. I'd also used skipped in this case too.

[hainest]

Looks good. Two optional things:

1. It would be nice have the test use SKIPPED with a message instead of silently be not run so it is visible.  That's what I did in on the branch kupsch/filter-DSOs-to-parse.

Yeah, that would be nicer behavior. I'll convert it to a runtime check in the mutator and add an error message that will show up with ctest --verbose.

2. Also the AI suggests: `The cleaner fix is to make DYNINST_ENABLE_STATIC_TESTS default to OFF when the target is aarch64. That keeps one control point users can override, and it also covers any future static tests added in other directories.` I'd also used skipped in this case too.

That controls just this test today, but there could be others in the future that don't try to rewrite the binary. I think having each test determine what it should do is the best route for now.

[hainest]

@kupsch I marked it as disabled instead of skipped.

Test project /home/users/thaines/workspace/hopper/paradyn/build/external-tests
    Start 1: common_includes
1/7 Test #1: common_includes ..................   Passed    0.01 sec
    Start 2: dynC_API_includes
2/7 Test #2: dynC_API_includes ................   Passed    0.02 sec
    Start 3: dyninstAPI_static_ctor_dtor
3/7 Test #3: dyninstAPI_static_ctor_dtor ......***Not Run (Disabled)   0.00 sec
    Start 4: parseAPI_simpleParser
4/7 Test #4: parseAPI_simpleParser ............   Passed    0.03 sec
    Start 5: symtab_includes
5/7 Test #5: symtab_includes ..................   Passed    0.04 sec
    Start 6: e_parser
6/7 Test #6: e_parser .........................   Passed    0.01 sec
    Start 7: module_parser
7/7 Test #7: module_parser ....................   Passed    0.02 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   0.14 sec

The following tests did not run:
          3 - dyninstAPI_static_ctor_dtor (Disabled)