Skip to content

truename: drop trailing colon if not on pos 1 [fixes #310] - #311

Merged
stsp merged 1 commit into
masterfrom
dcolon
Oct 12, 2026
Merged

stsp merged 1 commit into
masterfrom
dcolon

Conversation

@stsp

@stsp stsp commented Oct 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@stuaxo

stuaxo commented Oct 12, 2026 •

Copy link
Copy Markdown

It doesn't seem to help.

Here's a simplified version of what copyit.bat does.

I've made a small .iso file you can use to test, I believe this may be an issue with device drivers like cdrom devices.

nubug-iso-and-test-bat.zip

If I run test.bat it fails at the md:

delete c:\tmp\nb before running:

echo off
c:\shsucdx.com /d:MSCD0001

g:

md c:\tmp\nb >nul:
echo md worked

copy g:\copyit.bat c:\tmp >nul:
echo copy worked

@stsp

stsp commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

Does this look any better?

@stuaxo

stuaxo commented Oct 12, 2026

Copy link
Copy Markdown

Yes, confirmed this works, the BRR installer works (using this branch with my bin+cue branch rebased on it).

I've got a couple of tests that cover this I can probably push as a new PR as well.

@stsp
stsp merged commit 2f10d8a into master Oct 12, 2026
2 checks passed
@stsp
stsp deleted the dcolon branch October 12, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants