Skip to content

Fix duplicate PDF page selections - #13850

Open
MALLADISARMA wants to merge 3 commits into
deepset-ai:mainfrom
MALLADISARMA:fix/deduplicate-pdf-page-range
Open

MALLADISARMA wants to merge 3 commits into
deepset-ai:mainfrom
MALLADISARMA:fix/deduplicate-pdf-page-range

Conversation

@MALLADISARMA

Copy link
Copy Markdown
Contributor

Fix for #13830

Summary

  1. Remove duplicate pages from expanded page ranges while preserving selection order.
  2. Ensure PDFToImageContent converts each selected page only once.
  3. Add tests for overlapping ranges and repeated page selections.

Tests

  • test/utils/test_misc.py
  • test/components/converters/image/test_pdf_to_image.py — 43 passed.

@MALLADISARMA
MALLADISARMA requested a review from a team as a code owner November 21, 2026 02:57
@MALLADISARMA
MALLADISARMA requested review from anakin87 and removed request for a team November 21, 2026 02:57
@vercel

vercel Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@MALLADISARMA is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Nov 21, 2026
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/utils
  misc.py
Project Total  

This report was generated by python-coverage-comment-action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant