Repository navigation
Fix BMP image resizing by mapping image/bmp to Pillow BMP format - #13748
adityav1709 wants to merge 1 commit into
Conversation
FORMAT_TO_MIME maps both BMP and DIB to image/bmp, so the inverted MIME_TO_FORMAT keeps DIB, which can neither open real .bmp files nor write valid ones. Resizing BMP images fails as a result. Map image/bmp to BMP, following the existing precedent that hand patches image/jpg to JPEG. Fixes deepset-ai#13742 Signed-off-by: adityav1709 <adityav170920@gmail.com> Co-authored-by: Muse (Aurora)
|
@adityav1709 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @adityav1709, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
|
Hi @adityav1709, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
Thanks for signing the CLA, @adityav1709! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
|
Closing as a duplicate of #13743 |
FORMAT_TO_MIME maps both BMP and DIB to image/bmp, so the inverted MIME_TO_FORMAT keeps DIB, which can neither open real .bmp files nor write valid ones, and resizing BMP images fails. This change maps image/bmp to BMP, following the existing precedent that hand patches image/jpg to JPEG. Includes a release note and regression tests. Fixes #13742. Built with Muse (Aurora) as co-author.