You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Exempt maintainers/bots and make closing more robust #320
#316 added .github/workflows/enforce_issue_link.yml, which auto-closes any PR that doesn't
reference (Closes #N) an issue assigned to the PR author. While reviewing it, I found a problem
problems.
The check runs on every pull_request_target event and has no exemptions. As written, it will
close:
PRs from maintainers (bug fixes, index.toml edits, repo maintenance)
PRs from bots such as Dependabot
The issue-first process is meant for external contributors proposing new notebooks.
Proposal: return early when the PR author is a bot (user.type === "Bot") or has author_association of OWNER, MEMBER or COLLABORATOR. Optionally, also add a paths:
filter so the check only applies to PRs touching notebooks/**.
Activity