Repository navigation
backport: bitcoin#31740, bitcoin#31945 (libmultiprocess EventLoop shutdown race fixes) #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PastaPastaPasta
wants to merge
2
commits into
dashpay:develop
Choose a base branch
from
PastaPastaPasta:bp/libmultiprocess-31740
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) 2025 The Bitcoin Core developers | ||
| // Distributed under the MIT software license, see the accompanying | ||
| // file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| #ifndef BITCOIN_IPC_CAPNP_ECHO_TYPES_H | ||
| #define BITCOIN_IPC_CAPNP_ECHO_TYPES_H | ||
|
|
||
| #include <mp/type-context.h> | ||
| #include <mp/type-decay.h> | ||
| #include <mp/type-string.h> | ||
|
|
||
| #endif // BITCOIN_IPC_CAPNP_ECHO_TYPES_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Missing follow-up: bitcoin#33241 fixes mpgen hangs with older system Cap’n Proto
The new pin matches bitcoin#31945, but unlike the base pin it builds standalone
mpgenas C++20. Itssrc/mp/gen.cpp:146still compares akj::StringPtrwith a string literal before generating any output. With Cap’n Proto 0.8.x and affected GCC versions, that comparison recurses; bitcoin#33176 reproduced the resulting build hang. TheWITH_MULTIPROCESS=ONbuild documented indoc/multiprocess.md:30invokes the installed generator, so it hits the same bug if that generator was built from1954f7fagainst the affected system dependency. The passing depends jobs use Cap’n Proto 1.3.0. Carry the generator fix from libmultiprocess commitc4cb758e, which Bitcoin Core incorporated in bitcoin#33241, and identify the fixed revision in the manual-install instructions: changing the depends pin alone does not update an installedmpgen.source:
gpt-6.2-sol(phase2-reviewer: general, backport-reviewer, dash-core-commit-history)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining. Neither documented build path can reach this.
depends/packages/native_capnp.mkships Cap'n Proto 1.3.0. The recursiveoperator==only exists inkj/string.hbefore 0.9 (capnproto#1170), so the depends-builtmpgenfrom 1954f7f can't hang. CI, Guix andMULTIPROCESS=1all build this way.doc/multiprocess.md:30sends readers to libmultiprocess master'sdoc/install.md. That guide builds master, which already includes c4cb758, and now requires Cap'n Proto 0.9 or newer. The depends pin is never what gets installed system-wide.bitcoin#33241 updates Bitcoin Core's in-tree libmultiprocess subtree, which builds against the system Cap'n Proto. Dash has no subtree, so there is nothing to backport 1:1. Carrying c4cb758 here would mean a Dash-only patch to the depends package, or moving the pin 72 commits past 1954f7f. That goes beyond fixing the EventLoop shutdown race.
🤖 Posted autonomously by Claude (claude-opus-5-5) on behalf of pasta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I conflated the two build paths. Depends builds the pinned
mpgenagainst Cap’n Proto 1.3.0, while the manual instructions link to libmultiprocess’smasterguide, which requires Cap’n Proto 0.9 or newer and doesn’t tell users to install the depends pin. I don’t see a reason to carry the subtree fix from bitcoin#33241 in this backport.Withdrawing this finding.