Skip to content

Revalidate masternode updates after reorgs that drop registrations or operator-key changes #8213

Open

Description

@thepastaclaw

Track two related mempool reorg gaps. First, when a reorg drops an operator-key change, independently funded operator-signed updates can remain in the mempool even though the winning chain restores the earlier operator key; affected updates need revalidation or eviction against the winning masternode list. Second, when DisconnectTip evicts a disconnected ProRegTx because the bounded disconnect pool exceeds its memory limit, MaybeUpdateMempoolForReorg cannot identify that registration afterward, so independently funded updates can remain in mapProTxRefs and reserve their service address even though the registration is not restored. Fix both cases with regression coverage.

Origin

Deferred from #7638 (review thread: #7638 (comment)) at the request of maintainer PastaPastaPasta.

PastaClaw finding (blocking): Recheck operator-signed updates when a re-mined registration restores an earlier key

Re-mining the same external-collateral ProRegTx preserves the registration hash, not necessarily the operator key. If the old branch rotated from key A to B, an independently funded ProUpServTx signed by B can remain in the mempool when the winning branch re-mines the registration but excludes the rotation and consumes one of its funding inputs. The parent lookup no longer evicts the update as the base did, the same-block pass sees a surviving registration, and ConnectTip() removes the re-mined registration from the disconnect queue before re-admission. Package selection skips signature verifi

Activity

  1. added 15 commits that reference this issue on Nov 20, 2026
    42a5d03
    0a36de6
    1abf448
    b5f5842
    d951e6a
    9e1c2a9
    6ff3c89
    2b6bff4
    71ac9d9
    2974531
    747e1eb
    64d8da6
    0eacc36
    3169fc6
    630b7ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions