Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
python scripts/bencher.dev.py benchres.csvon results from multiple allocators writes the same cross-allocator statistics into every allocator's JSON file. For example,cfractimes of 1/3 seconds forsysand 10/14 seconds formiproduce a mean of 7 seconds in both files, instead of 2 and 12 seconds respectively. Memory mean/min/max are mixed in the same way.The allocator enumeration also uses the last parsed benchmark, so allocators that only ran other benchmarks disappear from the output.
Change
Enumerate allocators from the full input and compute each benchmark's statistics using only that allocator's samples. Omit benchmark/allocator combinations with no samples. Preserve the existing output schema and filenames.
Validation
python -m unittest discover -s scripts -p test_bencher.py -v: two CLI regression tests fail on the base implementation and pass with this change (all six statistics and differing benchmark selections).git diff --checkpasses.benchres.csvfixtures, not measured performance comparisons. No full allocator builds or stress benchmarks were run.