Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"server-destroy": "^1.0.1",
"standard": "^9.0.0",
"tap": "^15.1.5",
"tape": "^4.6.0"
"tape": "^5.0.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tape v5 silently weakens t.equal to loose equality

Medium Severity

Upgrading tape from v4 to v5 changes t.equal from strict equality (===) to loose equality (==). This silently weakens all existing t.equal assertions across the test suite. Notably, t.equal(err, null) now also passes when err is undefined, and t.equal(body, undefined) now also passes when body is null. Multiple test files rely on these comparisons (e.g., test-emptyBody.js, test-gzip.js, test-defaults.js, test-baseUrl.js). Tests will continue to pass but with looser guarantees, potentially masking real bugs in the library. Existing t.equal calls need migration to t.strictEqual to preserve the original strict semantics.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit fa4a01d. Configure here.

},
"greenkeeper": {
"ignore": [
Expand Down
Loading
Loading