Repository navigation
fix: clarify no-alert selection - #1704
Merged
Merged
Conversation
Deploying edgewatch with
|
| Latest commit: |
c94a7d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47a75503.edgewatch-cpd.pages.dev |
| Branch Preview URL: | https://t3-rename-no-alerts-choice.edgewatch-cpd.pages.dev |
crypt0rr
changed the title
crypt0rr
force-pushed
the
t3/rename-no-alerts-choice
branch
2 times, most recently
from
October 25, 2026 16:27
25f4fff to
e704cf4
Compare
crypt0rr
force-pushed
the
t3/rename-no-alerts-choice
branch
from
October 25, 2026 16:44
e704cf4 to
c94a7d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1701
Summary
Rename the no-alert choice to “Use no alerts” so it describes selecting an empty alert destination list. Keep the selection on the notification step, preserve its status announcement and draft state, and retain the explicit Review monitor action and role-specific guidance. Add regression coverage for administrator and operator flows, keyboard selection/review, and narrow layout. Update the first-scan guide.
Validation
npm run lint— passednpm run build— passednpm run test:coverage— passed (794 tests)npm --prefix docs run build— passed; local preview reviewedPLAYWRIGHT_PORT=4175 npm run test:e2e -- e2e/guided-monitor-setup.spec.ts— 13 passed, 31 skippedux-followups.spec.tsnavigation failure in [P4] Button labels still wrap to two lines (61 px beside 44 px buttons), and ghost buttons at a column edge look inset (follow-up to #993) #1130; a focused retry on that head also failed, while a separate retry in the [P3] Search the public host picker by address and job #1700 coordination thread passed. No [P4] Button labels still wrap to two lines (61 px beside 44 px buttons), and ghost buttons at a column edge look inset (follow-up to #993) #1130 code or fixture changed.Hosted checks can provide the final gate.