Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
=======================================
Coverage 55.75% 55.75%
=======================================
Files 65 65
Lines 3024 3024
=======================================
Hits 1686 1686
Misses 1338 1338 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small inline editing parses textarea values and ordinary submitted values as HTML. This change creates native input/textarea controls and assigns their
.value, then displays ordinary saved values and select labels withtextContent. Explicit non-empty server HTML replacements retain their existing renderer behavior.Explicit editable values preserve whitespace and entities. Without an explicit value, the editor reads rendered text with BR elements as newlines. Change detection compares against the native control's normalized value, avoiding unintended saves for CRLF and constrained input types. Select values are assigned without interpolating them into a selector.
The patch follows the merged #1323 lifecycle fix. It leaves the editable-value synchronization in #1297 to that PR.
Validation:
make playwright: 64 checks pass on desktop Chromium and a mobile touch profile, using actual Naja/NajaAjax. Coverage includes literal textarea values from escaped attributes, saved text and select labels, whitespace/entities, native normalization, unchanged edits and server HTML replacements.b26829562c3d210055bc2563d8a30fd012373f52and pass with this patch.npm run buildpasses with the existing Naja type and CSS output warnings.npx tsc --noEmit --allowJs falseproduces identical diagnostics on master and this patch (existing TS2322 atassets/ajax/naja.ts:113).