Skip to content

Add reason to ControllerUnpublishVolumeRequest - #613

Merged
saad-ali merged 1 commit into
container-storage-interface:masterfrom
torredil:cs-610
Nov 5, 2026
Merged

saad-ali merged 1 commit into
container-storage-interface:masterfrom
torredil:cs-610

Conversation

@torredil

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds an optional reason field to ControllerUnpublishVolumeRequest that lets COs give SPs more context about out of sequence ControllerUnpublishVolume calls.

Which issue(s) this PR fixes:

Fixes #610

Does this PR introduce an API-breaking change?:

NONE.

@torredil

Copy link
Copy Markdown
Contributor Author

cc: @bswartz @gnufied PTAL, thanks!

@huww98

huww98 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

How do you plan to implement this in external-attacher? Do we add a new field to VolumeAttachment?

Comment thread csi.proto Resolved
Comment thread csi.proto Resolved
Comment thread csi.proto Resolved
Comment thread csi.proto Resolved
@torredil

Copy link
Copy Markdown
Contributor Author

@huww98 external-attacher can set the reason from the Node's state, or like you said we can add a new field. Happy to discuss more in sig implementation and file a small KEP if we need to settle the point (but however k8s fills it in, it doesn't change what the field means in the spec).

@torredil
torredil requested a review from bswartz October 23, 2026 16:08

@bswartz bswartz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gnufied

gnufied commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@torredil can you make a small KEP for this and how it will be integrated with k8s?

@gnufied

gnufied commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

lgtm

Comment thread csi.proto Resolved
@gnufied

gnufied commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@saad-ali

saad-ali commented Nov 5, 2026

Copy link
Copy Markdown
Member

It makes me a little uncomfortable to add "do what you will with it" information as part of a strict API contract. I am worried it could lead to unexpected undocumented dependencies.

That said, given the wording here is pretty clear, I won't block this.

Merge conflict needs to be resolved to merge.

/lgtm
/approve

Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil

torredil commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @saad-ali, I fixed the merge conflict.

@saad-ali
saad-ali merged commit fd2dbb3 into container-storage-interface:master Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal node-out-of-service state in ControllerUnpublishVolume

5 participants