Repository navigation
Add reason to ControllerUnpublishVolumeRequest - #613
Conversation
|
How do you plan to implement this in external-attacher? Do we add a new field to |
|
@huww98 external-attacher can set the reason from the Node's state, or like you said we can add a new field. Happy to discuss more in sig implementation and file a small KEP if we need to settle the point (but however k8s fills it in, it doesn't change what the field means in the spec). |
|
@torredil can you make a small KEP for this and how it will be integrated with k8s? |
|
lgtm |
|
/lgtm |
|
It makes me a little uncomfortable to add "do what you will with it" information as part of a strict API contract. I am worried it could lead to unexpected undocumented dependencies. That said, given the wording here is pretty clear, I won't block this. Merge conflict needs to be resolved to merge. /lgtm |
Signed-off-by: Eddie Torres <torredil@amazon.com>
|
Thank you @saad-ali, I fixed the merge conflict. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds an optional reason field to
ControllerUnpublishVolumeRequestthat lets COs give SPs more context about out of sequenceControllerUnpublishVolumecalls.Which issue(s) this PR fixes:
Fixes #610
Does this PR introduce an API-breaking change?: