You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(vercel): check every server import resolves inside function - #66
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5a073fb8-f3ec-4980-ae05-09b7884ee175
📥 Commits
Reviewing files that changed from the base of the PR and between 2a35a14 and b3abe8f.
📒 Files selected for processing: 3
test/e2e/bundle.test.ts
test/server-bundle.ts
test/vercel/output.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The pull request moves server-bundle import validation into a shared test helper. The end-to-end bundle test and Vercel output test both use the helper.
Adds a helper that scans bundled .mjs files, checks import resolution, and asserts that validation covers imports and finds no external bundle dependencies.
Use the shared helper in bundle tests test/e2e/bundle.test.ts, test/vercel/output.test.ts
Replaces the end-to-end test’s inline checks with the helper and adds a helper call to the Vercel output test.
No concrete merge-blocking issue is established. The new Vercel check runs after the build in CI; validation against the generated function output remains worthwhile.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the Vercel test and the main change: verifying that server imports resolve within the deployed function bundle.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the server bundle import check on the Vercel function too, not only on the node-server output.
test/e2e/bundle.test.tsto a sharedexpectSelfContainedBundle(serverDir)helper (test/server-bundle.ts), unchanged.output/server, thevercelproject now also checks.vercel/output/functions/__fallback.funcnode_modulesworks locally but fails once deployedNo CI change: the
verceljob already runspnpm test:vercel.🤖 Generated with Claude Code, reviewed by @larbish before opening.
Summary by CodeRabbit