Repository navigation
pmd omit default window bits - #3121
Merged
Merged
Conversation
… offer The client's offer always carried server_max_window_bits=15, which only restates the permessage-deflate default: a response value can never exceed 15, and omitting the parameter already permits a 32 KiB window. Some servers decline or fail offers carrying the parameter at all, while every mainstream client omits it. Omit the parameter when the option is 15. A smaller limit is still offered, and the server may still select a smaller window in its response (RFC 7692 7.1.2.1). Sending an explicit server_max_window_bits=15 now requires a request decorator. Fixes boostorg#2671
client_max_window_bits=15 only hints at the 32 KiB cap that RFC 7692 7.2.1 imposes on every sender. The valueless form carries the same meaning, keeps the server free to select the client's compression window, and is the form the major clients offer. Send the bare parameter when the option is 15; a smaller value is still sent with the value as before.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3121 +/- ##
========================================
Coverage 94.00% 94.00%
========================================
Files 177 177
Lines 13898 13898
========================================
Hits 13065 13065
Misses 833 833
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://3121.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-20 06:09:47 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2671