Repository navigation
Honor --delete_problematic_images during Webshart streaming training - #3416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming Webshart Parquet training could stop on a corrupt image. The reader omitted the row, and the batch loader then failed while reconstructing the requested batch. Enabling
--delete_problematic_imagesalso forced a full catalogue scan before training.With the flag enabled, the sampler now records unreadable rows in the metadata cache for the affected shard revision. It fills empty slots from the same aspect-ratio bucket before resolving captions and conditioning. If necessary, it repeats a readable row to keep each rank’s batch full. All ranks advance past a bucket with no readable rows. Pixel training and on-demand VAE encoding reuse the decoded images.
Verification