Repository navigation
Potential fix for code scanning alert no. 2: Incomplete URL substring sanitization - #200
Draft
neatudarius wants to merge 1 commit into
Draft
neatudarius wants to merge 1 commit into
neatudarius wants to merge 1 commit into
Conversation
… sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
✅ Deploy Preview for bemanproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bemanproject/website/security/code-scanning/2
Use proper URL parsing and validate the hostname explicitly instead of substring matching.
Best fix in this file:
scripts/run-staged-website.py, updateyoutube_embedto:urllib.parse.urlparse.hostnameagainst exact allowed hosts (youtube.com,www.youtube.com,m.youtube.com,youtu.be).youtu.be, extract video ID from path.youtube.comvariants, extractvfrom parsed query parameters (parse_qs) instead of string splitting.urlwhen no valid video ID is found.parse_qsandurlparsefromurllib.parse.This preserves functionality while removing the unsafe substring host check.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.