Skip to content

ci: log in to Public ECR before the durable-functions PR lane #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnusunny wants to merge 1 commit into from
+24 −0
Closed

ci: log in to Public ECR before the durable-functions PR lane #9363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ jobs:
name: Integ / ${{ matrix.os }} / ${{ matrix.python }} / ${{ matrix.tests_config.name }}
if: github.repository_owner == 'aws'
runs-on: ${{ matrix.os }}
permissions:
id-token: write # Required for OIDC (Public ECR login)
contents: read
env:
AWS_DEFAULT_REGION: us-east-1
SAM_CLI_DEV: "1"
Expand Down Expand Up @@ -192,6 +195,27 @@ jobs:
run: make init
- name: uv install setuptools in Python3.12
run: uv pip install --break-system-packages --python "$(uv python find 3.12)" --upgrade pip setuptools
# Anonymous Public ECR pulls of the emulator image hit "toomanyrequests: Data limit exceeded".
# Fork PRs get no secrets or OIDC token, so they stay anonymous.
- name: Configure AWS credentials via OIDC
id: aws-creds
if: ${{ matrix.tests_config.name == 'durable-functions' && (github.event_name == 'merge_group' || github.event.pull_request.head.repo.full_name == github.repository) }}
continue-on-error: true
uses: aws-actions/configure-aws-credentials@cbe3b392738ccf3f987d68400dafcf4b0624a56c # v6
with:
role-to-assume: ${{ secrets.OIDC_ROLE_ARN }}
aws-region: us-east-1
# Keep the credentials out of the test step's environment
output-env-credentials: false
output-credentials: true
- name: Log in to Public ECR
if: ${{ steps.aws-creds.outcome == 'success' }}
continue-on-error: true
env:
AWS_ACCESS_KEY_ID: ${{ steps.aws-creds.outputs.aws-access-key-id }}
AWS_SECRET_ACCESS_KEY: ${{ steps.aws-creds.outputs.aws-secret-access-key }}
AWS_SESSION_TOKEN: ${{ steps.aws-creds.outputs.aws-session-token }}
run: aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws
- name: Run integration tests for ${{ matrix.tests_config.name }}
run: pytest -vv ${{ matrix.tests_config.params }}
env:
Expand Down
Loading