Repository navigation
Conversation
Contributor
|
Thanks for the contribution. Please create Jira tickets. We cannot accept patches without associated Jira tickets. |
Author
Author
|
Created ZOOKEEPER-5105 for this PR, ZOOKEEPER-5106 for #2479 and ZOOKEEPER-5107 for #2480, and updated the titles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zkCli keeps a single
AddWatchCommandinstance for the whole session, andparse()only assignedmodewhen-mwas given. AfteraddWatch -m PERSISTENT /a, a lateraddWatch /bin the same session silently registered aPERSISTENTwatch instead of the defaultPERSISTENT_RECURSIVE.parse()now falls back to the default mode when-mis absent, the same wayReconfigCommand.parse()resets its per-invocation fields.Testing
ZooKeeperTest#testAddWatchWithoutModeUsesDefaultModerunsaddWatch -m PERSISTENT /aand thenaddWatch /bthrough oneZooKeeperMain; it fails without the fix (/bshows up among the persistent watches) and passes with it.org.apache.zookeeper.cli.*Test,ZooKeeperTest,RemoveWatchesCmdTest,ZooKeeperQuotaTest,EnforceQuotaTestand the persistent watcher tests pass; checkstyle and spotbugs report no issues.bin/zkCli.shagainst a standalone server: afteraddWatch -m PERSISTENT /w1,addWatch /w2followed bycreate /w2/cnow firesNodeCreated path:/w2/c(before the fix it firedNodeChildrenChanged path:/w2).