Repository navigation
Sort where queries by an association the query filters on #16853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matrei
wants to merge
53
commits into
7.0.x
Choose a base branch
from
fix/15589-where-query-association-sort-7.0.x
base: 7.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,243
−195
Open
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
0676c67
Sort where queries by an association the query filters on
matrei b494caa
Document that a sort reaches one association away
matrei 2990df1
Revert "Document that a sort reaches one association away"
jdaugherty c0c5a80
Sort where queries by a nested association path
jdaugherty 5e71443
Sort by a nested association id through its foreign key
jdaugherty 2154153
Join an association for a sort with a left join
jdaugherty 1b70845
Join an association with a left join for every sort
jdaugherty ea2c5e8
Sort a paged criteria query by a nested association path
jdaugherty c6b4d61
Sort list by every entry of a sort map
jdaugherty b482d67
Join an association for a sort when the query is executed
jdaugherty 4646683
Apply a requested join type without criteria or a sort
jdaugherty e6343c4
Apply a join type that a criteria query requests
jdaugherty 4dabb45
Apply the join types of a subquery after its criteria
jdaugherty 226bbc8
Fetch a collection that a right join is requested for
jdaugherty d689aab
Recognize a join that criteria make through an alias
jdaugherty 97dbd76
Let a later fetch mode replace a requested join type
jdaugherty a34a260
Cover the default sort and data services in the upgrade notes
jdaugherty c5b0edb
Join a collection without fetching it unless a fetch is requested
jdaugherty f4ef5b1
Join a requested path through a collection in a subquery
jdaugherty 71b4535
Make the joins of a query when the query is executed
jdaugherty 6ce701e
Apply the session filters to a join requested for a collection
jdaugherty b9f26d4
Let a later fetch mode replace a join type in every query
jdaugherty 8ef8631
Join an association once for a sort by several of its properties
jdaugherty 9c59ac4
Sort a criteria query by an association path with order
jdaugherty 4988d60
Add the orders of a criteria query once its criteria are built
jdaugherty 97bd0e5
Fetch a collection that a query sorted by it asks to fetch
jdaugherty 5a94a73
Order a criteria query by an association id without a join
jdaugherty 7e847ed
Resolve a Query.Order in the criteria of an association against it
jdaugherty 75b5b4d
Do not fetch a collection through the left join of its criteria
jdaugherty 60450f9
Use a short alias for the subquery of a requested join
jdaugherty e8f7036
Correct two statements about a requested join type
jdaugherty cc58a3b
Apply a requested join type to updateAll and deleteAll
jdaugherty 1ab83ab
Reject a bulk join that MySQL cannot run with a clear error
jdaugherty 688440e
Fix the regressions in requested join types and association sorts
jdaugherty 0c81f00
Fix older join type and sort issues and correct the docs
jdaugherty 5e6dc8f
Reject a sort by a bag in a query that fetches another bag
jdaugherty 1313011
Fetch the associations of a requested join type and never filter a co…
jdaugherty b4e50b4
Reject a sort by an alias that the query does not define
borinquenkid 1e47513
fix(hibernate5): the fetch mode join of list() fetches with a left jo…
borinquenkid 9f2c781
Keep the root alias on the count of a paged list
jdaugherty 8df78b0
Count each instance once for a list that fetches a collection
jdaugherty 0c312b0
Reject a sort by a bag in list when it fetches another bag
jdaugherty f7ee8a3
Join a filtered collection with an inner join when another is fetched
jdaugherty deb2784
Cover an undefined sort alias and the list fetch mode in the upgrade …
jdaugherty 8c4df83
Reject a sort by a collection next to a fetch when either one is a bag
jdaugherty 01ede72
Give the subquery of a requested join an alias apart from the root
jdaugherty a6346ce
Keep a sort join under a fetch in the count of a paged list
jdaugherty bdd9a85
Reject a fetched bag at any depth next to a sort by a collection
jdaugherty a5bfa75
Keep a requested left join and load other fetched collections later
jdaugherty 0d97b4c
Apply the bag check to what a query actually loads
jdaugherty 056588e
Follow the values of a map when loading collections after a query
jdaugherty 3677b3a
Treat a fetch from the mapping as a fetch of the sorted collection
jdaugherty 7323d92
Sort by a path that starts with the alias of the queried class
jdaugherty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
237 changes: 222 additions & 15 deletions
237
grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/HibernateSession.java
Large diffs are not rendered by default.
Oops, something went wrong.
733 changes: 717 additions & 16 deletions
733
...ata-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsHibernateUtil.java
Large diffs are not rendered by default.
Oops, something went wrong.
302 changes: 261 additions & 41 deletions
302
...core/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateCriteriaBuilder.java
Large diffs are not rendered by default.
Oops, something went wrong.
460 changes: 397 additions & 63 deletions
460
...ibernate5/core/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateQuery.java
Large diffs are not rendered by default.
Oops, something went wrong.
243 changes: 223 additions & 20 deletions
243
...rnate5/core/src/main/groovy/org/grails/orm/hibernate/query/GrailsHibernateQueryUtils.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.